-
-
Notifications
You must be signed in to change notification settings - Fork 398
[pluggable monitor] add --silent
and --config
flags
#1497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cmaglie
merged 4 commits into
arduino:feature/pluggable-monitor
from
cmaglie:pluggable-monitor-flags
Oct 6, 2021
Merged
[pluggable monitor] add --silent
and --config
flags
#1497
cmaglie
merged 4 commits into
arduino:feature/pluggable-monitor
from
cmaglie:pluggable-monitor-flags
Oct 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
reviewed
Oct 6, 2021
silvanocerza
reviewed
Oct 6, 2021
silvanocerza
reviewed
Oct 6, 2021
silvanocerza
suggested changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes to make.
silvanocerza
reviewed
Oct 6, 2021
* rename --silent to --quiet * removed useless 'settings' variable * translation string for "Monitor port settings" in CLI mode
531e06b
to
34b629a
Compare
silvanocerza
approved these changes
Oct 6, 2021
d-a-v
pushed a commit
to d-a-v/arduino-cli
that referenced
this pull request
Oct 14, 2021
d-a-v
pushed a commit
to d-a-v/arduino-cli
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)This PR adds two flags to the
monitor
command of the CLI:--config/-c
allows to set configuration of the monitor port before opening for example:The available parameters and values can be obtained with the
--describe
flag.If an option is ambiguous it can be explicitly set using the configuration setting id followed by
=
and the desired setting value for example:--silent/-s
will set the CLI in silent mode and will print only the output incoming from the port. This option is enabled automatically when the output of the CLI is redirected to a file but it can be forced with the-s
flag if the autodetection do not work for some reason.